Fix for ".nomedia" paths and deletes in Viewer #1417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juergen Kellerer <[email protected]>
skjnldsv
requested changes
Oct 25, 2022
There was a problem hiding this comment.
Hey, the Fix 'source' URL in viewer part seems far too complicated.
I have plans to fix this for 26. Until then, I would like to keep the code simple.
Please strip this out from this PR and open a dedicated one for it so we can discuss this separately :)
jkellerer
force-pushed
the
fix/nomedia-and-viewer
branch
from
0294851 to
96bae5a
Compare
jkellerer
changed the title
Signed-off-by: Juergen Kellerer <[email protected]>
jkellerer
force-pushed
the
fix/nomedia-and-viewer
branch
from
96bae5a to
da7e5eb
Compare
skjnldsv
approved these changes
Oct 26, 2022
skjnldsv
reviewed
Oct 26, 2022
Signed-off-by: Juergen Kellerer <[email protected]>
jkellerer
force-pushed
the
fix/nomedia-and-viewer
branch
from
e8b70af to
8b4cab1
Compare
|
@artonge anything missing for this pr? Looks complete and has an approval. If Cypress fail is related is unclear since the logs expired |
This was referenced May 3, 2023
This was referenced Nov 10, 2023
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a collection of
32 fixes in 2 commits:Source URL could be invalid and this broke sidebar, download and file-editing in the Viewer. The URL derives from- moved to Fix 'source' URL in viewer #1419.filenamebut this was not consistently built (sometimes with, sometimes without prefix). This change ensuresfilenameis consistent and a valid URL can always be built$store.appendFilesmay filter files in.nomediapaths but the callers ofappendFilesdidn't evaluate whether the method really appended all files, leading to broken references. This change ensures that only files that were really appended will be considered.Delete Fileaction inside theViewerwas not propagated to thePhotosapp (the view still contained deleted files and caused failures when trying to get the file from the server).Hope this found useful. Had only fixed the most serious problems I found when trying the app.
Feel free to reject or accept the PR or individual commits of it.